Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add grooveshark backend #101

Merged
merged 3 commits into from Apr 25, 2015
Merged

Conversation

camilonova
Copy link
Contributor

@coveralls
Copy link

Coverage Status

Coverage remained the same at 32.69% when pulling dde939b on camilonova:add-grooveshark into eb58e74 on woutervanwijk:develop.

@kingosticks
Copy link
Member

Shame it doesn't have a font awesome icon yet (FortAwesome/Font-Awesome#2844)

kingosticks added a commit that referenced this pull request Apr 25, 2015
@kingosticks kingosticks merged commit eeb9b2f into pimusicbox:develop Apr 25, 2015
@kingosticks
Copy link
Member

Thanks.

@camilonova
Copy link
Contributor Author

@kingosticks shame is they have a PipedPier icon and not a grooveshark one ;)

I have tried to understand where this icon is shown, can you tell?

@kingosticks
Copy link
Member

to the left of the track in pretty much all the pages. helps people tell which backend their search result came from, for example.

@kingosticks
Copy link
Member

And in fact, not just tracks, pretty much anything.

@camilonova
Copy link
Contributor Author

Saw it.

screen shot 2015-04-25 at 11 36 22 am

@kingosticks
Copy link
Member

But not when you get the tracks from the Browse page (see #99)

@kingosticks
Copy link
Member

actually, that is complete rubbish (I should have checked), it works perfectly from the Browse page too.

@kingosticks
Copy link
Member

Grooveshark has since closed down. Might as well remove this now.

@kingosticks kingosticks self-assigned this Jun 16, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants