New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Such Project, Much GUIs #6

Closed
pazos opened this Issue Jun 21, 2018 · 18 comments

Comments

Projects
None yet
4 participants
@pazos
Copy link

pazos commented Jun 21, 2018

Can you please explain me why two gui's for wownero? Is the sumokoin gui intended to replace the other one or each one is for a different purpose?

Remember than the sumokoin gui is just a wrapper to monero-wallet-rpc, and its basically a html page with some controls embedded. Not sure if its secure or not but pyside seems old and I can't find a proper event filter (e.g: to prevent click hijacking).

On the other side the monero gui is full of features that wownero may not need (support for ios/android, support for bootstrapping, remote nodes, support for detached daemon manager, etc).

@bomb-on

This comment has been minimized.

Copy link
Member

bomb-on commented Jun 22, 2018

Can you please explain me why two gui's for wownero?

Yes. I am comparing which of two is more maintainable, at least for me, since I am the one (of two) trying to make something out of it. I have 0 experience with QML, C, C++ and related but a lot of experience with Python.

Is the sumokoin gui intended to replace the other one or each one is for a different purpose?

Both should serve the same purpose, but I think that at this point no one can say for sure which one will do that in the end.
The Monero GUI fork was never properly compiled because of lack of operating systems (Windows mostly on my side) and because of lack of time to dedicate to compile static versions which would make everyone super happy. I personally don't have a lot of experience with mentioned C and therefore with compiling process and it's tricks either. On the other side, Sumokoin version was very easy to handle (on my side) but I still miss that Windows machine and some free time to figure out how to even compile something there. It also needs proper testing on Linux machines, so that brings us to 2 never-finished GUI versions at the moment.

Remember than the sumokoin gui is just a wrapper to monero-wallet-rpc, and its basically a html page with some controls embedded.

I am personally very aware of that and I think rest of devs are too.

Not sure if its secure or not but pyside seems old and I can't find a proper event filter (e.g: to prevent click hijacking).

God bless the one who wants to click-hijack Wownero GUI wallet for any purpose in this world. I assume that would mean that Wownero actually has some value. :)
But yes, you might have the point there and that might not be the only "feature" it lacks...

On the other side the monero gui is full of features that wownero may not need (support for ios/android, support for bootstrapping, remote nodes, support for detached daemon manager, etc).

All stated is 100% correct and I personally 100% agree :)
However, I probably don't have enough knowledge, instruments and (the most important) time to handle all that by myself. I tried, really did, but i probably spent 10x more time than someone else would and yet I delivered half-finished product. I personally would really like to see more people involved in something they will eventually use themselves (especially because I almost always use cli anyways) but that's probably a topic for some other discussion.

All that said, Wownero GUI wallet is definitely not finished yet and I think that there is no definite decision which of two versions (or maybe even some third?) will be developed in the future.

@bomb-on bomb-on added the question label Jun 22, 2018

@pazos

This comment has been minimized.

Copy link

pazos commented Jun 22, 2018

@bomb-on thanks for the feedback.

God bless the one who wants to click-hijack Wownero GUI wallet for any purpose in this world. I assume that would mean that Wownero actually has some value. :)

Good to know, please send me some wownero when you have time :p

All that said, Wownero GUI wallet is definitely not finished yet and I think that there is no definite decision which of two versions (or maybe even some third?) will be developed in the future.

Being so WOW, I think wownero deserves its own frontend. Maybe sumokoin idea isn't bad (i mean the wrapper around rpc wallet) but I would ditch pyside and go for qt instead (for the frontend) and lua to encode/decode json queries. This way the gui can be easily extendable (based on current rpc methods) without much C++ understanding.

@bomb-on

This comment has been minimized.

Copy link
Member

bomb-on commented Jun 23, 2018

@bomb-on thanks for the feedback.

You are more than welcome!

Good to know, please send me some wownero when you have time :p

All my wow is safely locked on various exchanges in forms of 5000+ satoshi sell orders, so this might be a bit difficult :)

Being so WOW, I think wownero deserves its own frontend.

Agree.

Maybe sumokoin idea isn't bad (i mean the wrapper around rpc wallet) but I would ditch pyside and go for qt instead (for the frontend) and lua to encode/decode json queries. This way the gui can be easily extendable (based on current rpc methods) without much C++ understanding.

Tbh, I am open for any "solution" but because of lack of experience with cross-platform GUI apps in general is at this moment I am unable to decide which of mentioned paths would be "the best", while "the easiest to maintain" in the same moment :) I like the idea of making a wrapper around existing binaries very much and I will definitely try to google a bit about your suggestions! If you feel like you can share some hints and tips feel free to do so, or even better, join us in #wownero on IRC and let's have a quick chat about it sometimes...

@pazos

This comment has been minimized.

Copy link

pazos commented Jun 26, 2018

I did some work today on a new gui. It is just a showcase, showing a dashboard tab. Was tested on linux against monerod, not wownerod, but should work on both.

My idea is implement other components as closable tabs, leaving the dashboard always opened. I'm not sure what is the best idea, maybe a tab per wallet? maybe one tab per view (transfer,receive,history)?. Feedback would be WOW!

error:

isrunning

wizard:

wizard
read-only
needmorespace

dashboard:

starting
loading
dashboard

@xmrdsc

This comment has been minimized.

Copy link

xmrdsc commented Jun 26, 2018

My feedback: wow. Do you have a branch where we can follow your progress?

Keep it up!

@pazos

This comment has been minimized.

Copy link

pazos commented Jun 26, 2018

And now supports quotes & lua scripting 😄

quotes
quotes2

@skftn: thanks. Don't have a branch because the code still sucks, but when I have something that works for somebody I will push it.

@bomb-on

This comment has been minimized.

Copy link
Member

bomb-on commented Jun 27, 2018

@pazos I am speechless! :) This work is stellar!!

About your UI dilemma, I would go with using tabs for wallet functions (transfer, receive, history, etc.) and I wouldn't allow using multiple wallets in the same time.

And OMG, are those quotes for IRC?? :D

@pazos

This comment has been minimized.

Copy link

pazos commented Jun 27, 2018

About your UI dilemma, I would go with using tabs for wallet functions (transfer, receive, history, etc.) and I wouldn't allow using multiple wallets in the same time.

This is way easier so I'm going to do that. Not sure about the workflow. Bitcoin-qt is tied to a specific wallet.dat and allow us to import/generate all new adresses we want. Monero-gui remembers last open wallet and ask for a password at start.

I like the decred way. Recover/create a new wallet on start and use that unless the user closes it. Then wizard again.

I think suchwallet needs to be KIWS (keep it Wow & stupid) and skip all the open/close wallet nonsense.

And OMG, are those quotes for IRC?? :D

I copied those from IRC. They are stored in a lua table.

@xmrdsc

This comment has been minimized.

Copy link

xmrdsc commented Jun 27, 2018

a lua table

wow

@pazos

This comment has been minimized.

Copy link

pazos commented Jun 27, 2018

Here suchwallet running on wownero network 👍

Such fast sync 📦

wow

@pazos

This comment has been minimized.

Copy link

pazos commented Jun 27, 2018

implemented interactive console for daemon (instead of using rpc to communicate, which is slower).
Need to add completion to the lineEdit and history capabilities, and maybe filter function address/types from the output

console-log
console-help

@pazos

This comment has been minimized.

Copy link

pazos commented Jun 28, 2018

I'm going full bitcoin-core in behaviour/visuals. So I implemented a "Debug Window" and moved consoles there.
debug
main debug

@pazos

This comment has been minimized.

Copy link

pazos commented Jun 30, 2018

@wowario @bomb-on @skftn @jwinterm

At the end I'm going to integrate all the widgets in the mainwindow, a la Electrum and use monero wallet api instead of the wallet_rpc 💃

Logic:

Dashboard tab always visible
Transfer, receive & history tabs visible when wallet is opened.
Rest of tabs can be invoked from view menubar and closed from tab close icon.

Here is a sneak peak:

closable views (need to make addressbook visible only when wallet is opened)

1

one tab was invoked from the view menubar.

2

this tab can't be invoked again until that tab is closed.

3

basic support for completion (for daemon console)

4

@xmrdsc

This comment has been minimized.

Copy link

xmrdsc commented Aug 20, 2018

@pazos

Would love to see your code. I could expand on it (not sure if you're still working on it :D). Would be nice to get it working.

@pazos

This comment has been minimized.

Copy link

pazos commented Oct 4, 2018

@skftn: I didn't touch it since Juny. So it is not a wallet yet, just some basic frontend for monero/wownero daemons. I have no plans to do more work on this on the short term.

@xmrdsc

This comment has been minimized.

Copy link

xmrdsc commented Oct 4, 2018

@pazos Share source? ^^

@pazos

This comment has been minimized.

Copy link

pazos commented Oct 6, 2018

ofc, Will clean the messy parts and push to github next week.

I think I'm going to remove the lua/plugin system and other jokes

@wowario

This comment has been minimized.

Copy link
Member

wowario commented Nov 18, 2018

Wownero-Light-Wallet GUI is out now.

@wowario wowario closed this Nov 18, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment