New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Soft changes need to be more flexible #34

Closed
schlessera opened this Issue Feb 14, 2018 · 3 comments

Comments

3 participants
@schlessera
Member

schlessera commented Feb 14, 2018

The soft change detection currently only works for the file readme.txt (case-sensitive): https://github.com/wp-cli/checksum-command/blob/master/src/Checksum_Plugin_Command.php#L339-L345

This detection needs to be more flexible, to cover all case variations as well as different endings (.md).

See wp-cli/wp-cli#4681

@danielbachhuber danielbachhuber referenced this issue Apr 10, 2018

Closed

WP-CLI v1.5.1 release checklist #4766

8 of 8 tasks complete

emirpprime pushed a commit to emirpprime/checksum-command that referenced this issue Apr 13, 2018

Phil Banks
More flexible soft change checks (issue wp-cli#34)
- case insensitivity in filenames
- accept .md extension as well as .txt
@emirpprime

This comment has been minimized.

emirpprime commented Apr 13, 2018

Attempted fix #41

  • allow .md
  • case insensitivity in filenames

emirpprime pushed a commit to emirpprime/checksum-command that referenced this issue Apr 19, 2018

@emirpprime

This comment has been minimized.

emirpprime commented Apr 19, 2018

Repeated PR with working tests #43

@schlessera

This comment has been minimized.

Member

schlessera commented Apr 19, 2018

Fixed via #43

@schlessera schlessera closed this Apr 19, 2018

@schlessera schlessera added this to the 1.0.9 milestone Apr 19, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment