New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More flexible soft change checks (issue #34) #41

Closed
wants to merge 0 commits into
base: master
from

Conversation

2 participants
@emirpprime

emirpprime commented Apr 13, 2018

  • case insensitivity in filenames
  • accept .md extension as well as .txt
@emirpprime

This comment has been minimized.

emirpprime commented Apr 13, 2018

Ah - silly error. Any recommendations on how to test this? Is the only way to install another plugin that uses readme.md to test against?

@schlessera

This comment has been minimized.

Member

schlessera commented Apr 19, 2018

@emirpprime Yes, you need to use a plugin that actually exhibits the problematic behavior.

You can use the one that triggered the initial issue, it was document-gallery.

@schlessera

This comment has been minimized.

Member

schlessera commented Apr 19, 2018

@emirpprime You should also merge latest master, which fixes the memory issue with PHP 5.3 tests.

@schlessera schlessera closed this Apr 19, 2018

@schlessera

This comment has been minimized.

Member

schlessera commented Apr 19, 2018

😳 GitHub, why is this closed now???

I'm sorry, @emirpprime, I was just pushing the update to get the memory fix for PHP 5.3.

Something with the pull-request must have been messed up internally, because I pushed the change into your fork's master, which immediately closed the PR here.

Also I cannot seem to reopen it:
image 2018-04-19 at 5 29 04 pm

If you still care to add this functionality, please open a new PR with your changes. I'm very sorry for wasting your time here.

@schlessera

This comment has been minimized.

Member

schlessera commented Apr 19, 2018

For reference, here's a diff of the code:
image 2018-04-19 at 5 34 33 pm

@schlessera

This comment has been minimized.

Member

schlessera commented Apr 19, 2018

Continued in #43

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment