New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Indicate files included by wp-config.php #18

Merged
merged 7 commits into from Jul 6, 2017

Conversation

2 participants
@Sidsector9
Member

Sidsector9 commented Jun 29, 2017

Fixes #11

@danielbachhuber

Thanks @Sidsector9 ! Can you include functional tests please?

@Sidsector9

This comment has been minimized.

Show comment
Hide comment
@Sidsector9

Sidsector9 Jun 30, 2017

Member

@danielbachhuber This feature already has a functional test written by @rahul3883 , do you want me to add something more to the existing test case?

Member

Sidsector9 commented Jun 30, 2017

@danielbachhuber This feature already has a functional test written by @rahul3883 , do you want me to add something more to the existing test case?

@danielbachhuber

This comment has been minimized.

Show comment
Hide comment
@danielbachhuber

danielbachhuber Jun 30, 2017

Member

do you want me to add something more to the existing test case?

Yes please

Member

danielbachhuber commented Jun 30, 2017

do you want me to add something more to the existing test case?

Yes please

@Sidsector9

This comment has been minimized.

Show comment
Hide comment
@Sidsector9

Sidsector9 Jul 6, 2017

Member

@danielbachhuber Added a functional test

Member

Sidsector9 commented Jul 6, 2017

@danielbachhuber Added a functional test

@danielbachhuber danielbachhuber added this to the 1.1.3 milestone Jul 6, 2017

@danielbachhuber danielbachhuber changed the title from GH#11 Displays files included by wp-config.php to List files included by wp-config.php Jul 6, 2017

@danielbachhuber

This comment has been minimized.

Show comment
Hide comment
@danielbachhuber

danielbachhuber Jul 6, 2017

Member

Thanks, @Sidsector9 ! I had to make some formatting changes but looks good otherwise.

Member

danielbachhuber commented Jul 6, 2017

Thanks, @Sidsector9 ! I had to make some formatting changes but looks good otherwise.

@Sidsector9

This comment has been minimized.

Show comment
Hide comment
@Sidsector9

Sidsector9 Jul 6, 2017

Member

You're welcome @danielbachhuber
Also thanks to @rahul3883 for helping me out with writing the functional test.

Member

Sidsector9 commented Jul 6, 2017

You're welcome @danielbachhuber
Also thanks to @rahul3883 for helping me out with writing the functional test.

@danielbachhuber danielbachhuber merged commit 42502b7 into wp-cli:master Jul 6, 2017

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@danielbachhuber danielbachhuber changed the title from List files included by wp-config.php to Indicate files included by wp-config.php Jul 6, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment