New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix library version to `^1.2.1` #53

Merged
merged 2 commits into from Apr 19, 2018

Conversation

2 participants
@schlessera
Member

schlessera commented Apr 10, 2018

@schlessera schlessera added this to the 1.2.0 milestone Apr 10, 2018

@schlessera schlessera requested a review from wp-cli/committers Apr 10, 2018

@danielbachhuber

This comment has been minimized.

Show comment
Hide comment
@danielbachhuber

danielbachhuber Apr 10, 2018

Member

What if we instead added wp-cli/wp-config-transformer as a wp-cli/wp-cli dependency and had wp-make-coffee handle it?

And, taking a step back, why is this necessary? Shouldn't Composer install the latest automatically?

Member

danielbachhuber commented Apr 10, 2018

What if we instead added wp-cli/wp-config-transformer as a wp-cli/wp-cli dependency and had wp-make-coffee handle it?

And, taking a step back, why is this necessary? Shouldn't Composer install the latest automatically?

@schlessera

This comment has been minimized.

Show comment
Hide comment
@schlessera

schlessera Apr 10, 2018

Member

What if we instead added wp-cli/wp-config-transformer as a wp-cli/wp-cli dependency and had wp-make-coffee handle it?

No, I currently try to get away from having the framework depend on command requirements, as we have now with the Symfony dependencies that are actually only needed for the package manager. Related: wp-cli/wp-cli#4748

And, taking a step back, why is this necessary? Shouldn't Composer install the latest automatically?

It is not necessary for our Phar build, but it could avoid bugs for Composer builds where a hard requirement on the bug-fixed version shows errors when you try to use an older one.

Member

schlessera commented Apr 10, 2018

What if we instead added wp-cli/wp-config-transformer as a wp-cli/wp-cli dependency and had wp-make-coffee handle it?

No, I currently try to get away from having the framework depend on command requirements, as we have now with the Symfony dependencies that are actually only needed for the package manager. Related: wp-cli/wp-cli#4748

And, taking a step back, why is this necessary? Shouldn't Composer install the latest automatically?

It is not necessary for our Phar build, but it could avoid bugs for Composer builds where a hard requirement on the bug-fixed version shows errors when you try to use an older one.

@schlessera schlessera merged commit aa24eeb into master Apr 19, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@schlessera schlessera deleted the force-library-version-121 branch Apr 19, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment