New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adapt package for framework v2 #66

Merged
merged 5 commits into from Aug 4, 2018

Conversation

2 participants
@schlessera
Member

schlessera commented Aug 4, 2018

Fixes #65

@swissspidy

This comment has been minimized.

Show comment
Hide comment
@swissspidy

swissspidy Aug 4, 2018

Contributor

The only error seems to be:

Error: Can’t select database. We were able to connect to the database server (which means your username and password is okay) but not able to select the `wp_cli_test` database.

when trying to run wp db create.

The db command doesn't seem to be installed though. Shouldn't the error message be different then?

Contributor

swissspidy commented Aug 4, 2018

The only error seems to be:

Error: Can’t select database. We were able to connect to the database server (which means your username and password is okay) but not able to select the `wp_cli_test` database.

when trying to run wp db create.

The db command doesn't seem to be installed though. Shouldn't the error message be different then?

@schlessera

This comment has been minimized.

Show comment
Hide comment
@schlessera

schlessera Aug 4, 2018

Member

The nice thing is that the tests are now much more reliable and the failures are reproducible. So, now, a composer behat on local actually produces the same error. I'll investigate. I suppose it is the --verify of the config creation that fails because the db command errors out.

Member

schlessera commented Aug 4, 2018

The nice thing is that the tests are now much more reliable and the failures are reproducible. So, now, a composer behat on local actually produces the same error. I'll investigate. I suppose it is the --verify of the config creation that fails because the db command errors out.

@swissspidy

This comment has been minimized.

Show comment
Hide comment
@swissspidy

swissspidy Aug 4, 2018

Contributor

Ah makes sense.

I was so close to just require the db command like you just did now :-)

Contributor

swissspidy commented Aug 4, 2018

Ah makes sense.

I was so close to just require the db command like you just did now :-)

@schlessera

This comment has been minimized.

Show comment
Hide comment
@schlessera

schlessera Aug 4, 2018

Member

I tested first:

image 2018-08-04 at 3 49 08 pm

Member

schlessera commented Aug 4, 2018

I tested first:

image 2018-08-04 at 3 49 08 pm

schlessera added some commits Aug 4, 2018

@schlessera schlessera added this to the 1.2.1 milestone Aug 4, 2018

@schlessera schlessera merged commit 2468a25 into master Aug 4, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@schlessera schlessera deleted the adapt-for-v2 branch Aug 4, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment