Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace instances of `wp.dev` with `example.com` #115

Merged
merged 3 commits into from Apr 23, 2019

Conversation

@luc122c
Copy link
Contributor

commented Apr 18, 2019

Fixes #112.

Further to PR #114, I have replaced additional instances of wp.dev with example.com. There are still additional instances (1) and (2), however I am not familiar with this file type and have therefore not modified it.

wojsmol and others added some commits Apr 18, 2019

@luc122c luc122c requested a review from wp-cli/committers as a code owner Apr 18, 2019

@thrijith
Copy link
Member

left a comment

Thanks for the PR @luc122c and @wojsmol

@schlessera

This comment has been minimized.

Copy link
Member

commented Apr 18, 2019

@luc122c Can you add the two changes in the feature files to this PR as well to have one coherent change?

The feature files are the test files that are run through Behat, using the Gherkin syntax. They are pure text files, and as long as you only change the actual URL (keeping the indentation intact), you're perfectly fine.

@luc122c

This comment has been minimized.

Copy link
Contributor Author

commented Apr 23, 2019

@schlessera I have commited that further change. I'm not 100% sure how Github works, however it looks like that new commit has automatically been added to this existing Pull Request. If so, then this should resolve Issue #112.

@schlessera

This comment has been minimized.

Copy link
Member

commented Apr 23, 2019

@luc122c Yes, that worked. Committed to the branch that the PR was generated from will add these commits automatically to the PR.

@schlessera

This comment has been minimized.

Copy link
Member

commented Apr 23, 2019

Test failures are unrelated, merging anyway.

@schlessera schlessera added this to the 2.0.4 milestone Apr 23, 2019

@schlessera schlessera changed the title Replace instances of wp.dev with example.com Replace instances of `wp.dev` with `example.com` Apr 23, 2019

@schlessera schlessera merged commit 8821525 into wp-cli:master Apr 23, 2019

1 check failed

continuous-integration/travis-ci/pr The Travis CI build failed
Details
@schlessera

This comment has been minimized.

Copy link
Member

commented Apr 23, 2019

Thanks for the PR, @luc122c !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
4 participants
You can’t perform that action at this time.