Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove language translation check from core update process #192

wants to merge 7,696 commits into from


Copy link

@bgturner bgturner commented Sep 24, 2021

Fixes #191

gitlost and others added 30 commits November 13, 2017 14:36
Skip cache also when ZIP URL is 'http://' to nightly build

Update tests enable error reporting
* Regenerates
* Adds `.github/settings.yml` for description and label management.
* Updates `.github/PULL_REQUEST_TEMPLATE`
Ignore SSL trigger_error in WP get_core_checksums() on core upgrade.
Update scaffolded README and GitHub configuration
Convert core command help summaries to use third-person singular verbs.
Replace "install" with "installation" where appropriate
Convert 'install' -> 'installation' in all the correct places
@bgturner bgturner requested a review from a team as a code owner September 24, 2021 17:20
Copy link

This does prevent the markup and error within the terminal, but one apparent consequence is that the user needs to manually update translations, for example with the wp language subcommand. Is that still intended behavior, or should the core updater also queue the updates for the language translations?

@swissspidy swissspidy changed the title fix: #191 Remove language translation check from core update process Remove language translation check from core update process Sep 24, 2021
Copy link

The general philosophy of WP-CLI is that commands should only solve one single unique problem (i.e. updating core). It makes sense that the languages need to be updated separately via CLI.

Copy link

This will still need a test to ensure the language installation is reliably disabled across all WP versions.

Let me know if you need help getting started with Behat testing.

(I'll also have to figure out what the current test failures are about.)

Copy link

@bgturner Are you still up for working on this and implement the needed test?

Copy link

Sorry for dropping this. I've been pulled to other things. If someone else wants to take this initial work and run with it, I'd be happy for it to be solved.

Otherwise, I can probably circle around later in August

Copy link

Proceeding with wp-cli/wp-cli#5594 for this repository. I've captured this PR to in case this PR is auto-closed or broken in some way.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet

Successfully merging this pull request may close these issues.

Unexpected HTML output when updating WordPress