New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make use of 'halt_on_error' to catch error and release lock #38

Merged
merged 2 commits into from Oct 2, 2017

Conversation

2 participants
@danielbachhuber
Member

danielbachhuber commented Sep 29, 2017

Requires wp-cli/wp-cli#4383

Fixes #35

@danielbachhuber danielbachhuber added this to the 1.0.3 milestone Sep 29, 2017

@danielbachhuber danielbachhuber requested a review from wp-cli/committers Sep 29, 2017

@schlessera schlessera changed the title from Make use of 'throw_exception_on_error' to catch error and release lock to Make use of 'halt_on_error' to catch error and release lock Sep 29, 2017

@schlessera

This comment has been minimized.

Show comment
Hide comment
@schlessera

schlessera Sep 29, 2017

Member

@danielbachhuber Do you think we can test this, if we drop the cURL timeout to 1ms ?

Member

schlessera commented Sep 29, 2017

@danielbachhuber Do you think we can test this, if we drop the cURL timeout to 1ms ?

@danielbachhuber

This comment has been minimized.

Show comment
Hide comment
@danielbachhuber

danielbachhuber Sep 29, 2017

Member

@schlessera I was on the fence as to whether it would be useful to add a test (because it will always make an outbound HTTP request). Another thing we could test is a request to a domain that doesn't resolve. Your choice.

Member

danielbachhuber commented Sep 29, 2017

@schlessera I was on the fence as to whether it would be useful to add a test (because it will always make an outbound HTTP request). Another thing we could test is a request to a domain that doesn't resolve. Your choice.

@danielbachhuber danielbachhuber merged commit 5718f4b into master Oct 2, 2017

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@danielbachhuber danielbachhuber deleted the 35-catch-exception branch Oct 2, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment