New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ISO size formats to `db size` #104

Merged
merged 3 commits into from Jul 31, 2018

Conversation

3 participants
@fumikito
Contributor

fumikito commented Jul 20, 2018

  • Add new formats(Kib, KB and etc).
  • Add help comment.
  • Add scenario test.

Hope it helps!

Show outdated Hide outdated src/DB_Command.php
Show outdated Hide outdated src/DB_Command.php
@fumikito

This comment has been minimized.

Show comment
Hide comment
@fumikito

fumikito Jul 20, 2018

Contributor

@schlessera Thank you for your review. Sorry for my typo and now they are fixed!

Contributor

fumikito commented Jul 20, 2018

@schlessera Thank you for your review. Sorry for my typo and now they are fixed!

@miya0001 miya0001 self-requested a review Jul 21, 2018

@schlessera schlessera added this to the 1.3.5 milestone Jul 31, 2018

@schlessera schlessera merged commit c260be5 into wp-cli:master Jul 31, 2018

1 check was pending

continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
@schlessera

This comment has been minimized.

Show comment
Hide comment
@schlessera

schlessera Jul 31, 2018

Member

Thanks for the pull-request, @fumikito!

Member

schlessera commented Jul 31, 2018

Thanks for the pull-request, @fumikito!

@schlessera schlessera changed the title from Add size formats as described in issue #102 to Add ISO size formats to `db size` Jul 31, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment