Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pass `--column-statistics=0` to mysqldump command #105

Merged
merged 2 commits into from Jul 31, 2018

Conversation

2 participants
@miya0001
Copy link
Member

miya0001 commented Jul 20, 2018

Related: #103

@schlessera schlessera added this to the 1.3.5 milestone Jul 20, 2018

@@ -474,7 +474,15 @@ public function export( $args, $assoc_args ) {
$assoc_args['result-file'] = $result_file;
}
$command = '/usr/bin/env mysqldump --no-defaults %s';
$mysqldump_version = exec( "/usr/bin/env mysqldump --version --no-defaults" );
$mysqldump_version = preg_replace( "/^.+([0-9]+\.[0-9]+\.[0-9]+)(.+)$/", "$1", $mysqldump_version );

This comment has been minimized.

@schlessera

schlessera Jul 20, 2018

Member

This test does not take MariaDB into account.

Here's a version string from MariaDB from my current local setup:

$ /usr/bin/env mysqldump --version --no-defaults
mysqldump  Ver 10.16 Distrib 10.2.14-MariaDB, for osx10.13 (x86_64)

So you not only need to check the version, but also whether you actually are using MySQL, not some variant.

@miya0001

This comment has been minimized.

Copy link
Member Author

miya0001 commented Jul 20, 2018

@schlessera

I changed like following.

$support_column_statistics = exec( 'mysqldump --help | grep "column-statistics"' );

Because mysqldump --version on MySQL 8 returns like following, so I think this text is difficult to check whether we actually are using MySQL.

mysqldump  Ver 8.0.11 for osx10.13 on x86_64 (Homebrew)
@schlessera

This comment has been minimized.

Copy link
Member

schlessera commented Jul 20, 2018

Okay, let's try the change like this and monitor whether people still have issues with MySQL v8+ after that.

@schlessera schlessera merged commit 27dd210 into master Jul 31, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@schlessera schlessera deleted the mysqldump8-issues branch Jul 31, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.