New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds `--human-readable` parameter to `db size` command #124

Merged
merged 6 commits into from Dec 17, 2018

Conversation

3 participants
@pmgarman
Copy link
Contributor

pmgarman commented Dec 9, 2018

Solves #108

@swissspidy

This comment has been minimized.

Copy link
Contributor

swissspidy commented Dec 9, 2018

WordPress core has a size_format() function. Can we perhaps add a similar helper function to WP-CLI, maybe as part of the Utils lib?

@schlessera
Copy link
Member

schlessera left a comment

Looks good for the general approach. Let's add basic tests, then we're good for a merge.

Show resolved Hide resolved src/DB_Command.php Outdated
Show resolved Hide resolved src/DB_Command.php Outdated
Show resolved Hide resolved src/DB_Command.php

schlessera and others added some commits Dec 9, 2018

Update error more user friendly.
Co-Authored-By: pmgarman <patrick@garman.io>
Code formatting
Co-Authored-By: pmgarman <patrick@garman.io>
@schlessera

This comment has been minimized.

Copy link
Member

schlessera commented Dec 9, 2018

Tests currently failing because of #125

@pmgarman pmgarman changed the title WIP: Adds —human-readable parameter to db size command Adds —human-readable parameter to db size command Dec 10, 2018

@pmgarman pmgarman force-pushed the pmgarman:issue/108 branch from e5dc117 to 22a90cc Dec 10, 2018

@schlessera schlessera added this to the 2.0.1 milestone Dec 17, 2018

@schlessera schlessera merged commit 2ab6bd0 into wp-cli:master Dec 17, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@schlessera

This comment has been minimized.

Copy link
Member

schlessera commented Dec 17, 2018

Thanks for the PR, @pmgarman !

@schlessera schlessera changed the title Adds —human-readable parameter to db size command Adds `--human-readable` parameter to `db size` command Dec 17, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment