New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduces `wp db search` for searching through the database for a given string #29

Merged
merged 5 commits into from Jul 31, 2017

Conversation

3 participants
@gitlost
Contributor

gitlost commented Jul 29, 2017

Fixes #7

Merges https://github.com/runcommand/db-ack, with only cosmetic code changes apart from fixing the possible colorizing of percents in the search string, plus some small changes to the doc, plus extra tests.

Edit: changed the name from ack to the boring search so as not to clash with the original ack package installs plus ack is somewhat obscure even among techies.

Added regex and output formatting options.

@gitlost gitlost requested a review from wp-cli/committers Jul 29, 2017

@miya0001

There are some problem with multibyte string, I sent a PR which adds some tests for multibyte.
#30

@miya0001

It looks nice! 👍

@gitlost

This comment has been minimized.

Show comment
Hide comment
@gitlost

gitlost Jul 29, 2017

Contributor

Yes, all Daniel's work! It needs a --regex option and (for me anyway) a --colors option to be able to set different colors as I use a white console and the bright colors don't work that well on it...

Contributor

gitlost commented Jul 29, 2017

Yes, all Daniel's work! It needs a --regex option and (for me anyway) a --colors option to be able to set different colors as I use a white console and the bright colors don't work that well on it...

@danielbachhuber danielbachhuber added this to the 1.2.0 milestone Jul 31, 2017

@danielbachhuber

This comment has been minimized.

Show comment
Hide comment
@danielbachhuber

danielbachhuber Jul 31, 2017

Member

Edit: changed the name from ack to the boring search so as not to clash with the original ack package installs plus ack is somewhat obscure even among techies.

Good call, thanks @gitlost

Member

danielbachhuber commented Jul 31, 2017

Edit: changed the name from ack to the boring search so as not to clash with the original ack package installs plus ack is somewhat obscure even among techies.

Good call, thanks @gitlost

@danielbachhuber danielbachhuber merged commit 8574ba7 into master Jul 31, 2017

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@danielbachhuber danielbachhuber deleted the issue_7 branch Jul 31, 2017

@danielbachhuber danielbachhuber changed the title from Add ack command. to Introduces `wp db search` for searching through the database for a given string Aug 5, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment