New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change default regex delimiter to `chr(1)` #46

Merged
merged 2 commits into from Aug 30, 2017

Conversation

2 participants
@miya0001
Member

miya0001 commented Aug 30, 2017

The useful part is that it can return characters that you cannot easily type, so with something like chr(1), the chances of the delimiter being included in the pattern itself are practically null, whereas a / can easily be part of the actual pattern.

https://github.com/wp-cli/search-replace-command/pull/30/files/4d16b3163a4ef8d424e73aa74aba1b8c804508ef#r136037981

miya0001 added some commits Aug 30, 2017

@miya0001 miya0001 requested a review from wp-cli/committers Aug 30, 2017

@gitlost gitlost merged commit aab939f into master Aug 30, 2017

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@gitlost gitlost deleted the change-default-delimiter branch Aug 30, 2017

@gitlost gitlost added this to the 1.2.1 milestone Aug 30, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment