New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid displaying default delimiter on regex fail in db search. #56

Merged
merged 1 commit into from Oct 13, 2017

Conversation

2 participants
@gitlost
Contributor

gitlost commented Oct 13, 2017

Related #46 and wp-cli/search-replace-command#30

Avoids displaying default delimiter on regex fail in db search.

If a regex contains an error, then the message displayed appears like this in the default Gnome Terminal on Ubuntu 17.04:

regex_fail_default_before

and probably doesn't look any better in other environments.

This PR "spells out" the error message when using the default delimiter, eg:

regex_fail_default_after

(A similar PR would need to be done for search-replace.)

@danielbachhuber danielbachhuber added this to the 1.2.4 milestone Oct 13, 2017

@danielbachhuber

This comment has been minimized.

Show comment
Hide comment
@danielbachhuber

danielbachhuber Oct 13, 2017

Member

(A similar PR would need to be done for search-replace.)

Done in wp-cli/search-replace-command#40

Member

danielbachhuber commented Oct 13, 2017

(A similar PR would need to be done for search-replace.)

Done in wp-cli/search-replace-command#40

@danielbachhuber danielbachhuber merged commit 1379a28 into master Oct 13, 2017

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@danielbachhuber danielbachhuber deleted the regex_fail_default branch Oct 13, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment