New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add `wp db clean` command #93

Merged
merged 14 commits into from May 8, 2018

Conversation

2 participants
@marksabbath
Contributor

marksabbath commented Mar 26, 2018

wp db clean

Introducing new wp db clean. This new command drops only the tables that are present in $table_prefix.

@marksabbath

This comment has been minimized.

Show comment
Hide comment
@marksabbath

marksabbath Mar 26, 2018

Contributor

Will take a look at the errors later today.

Contributor

marksabbath commented Mar 26, 2018

Will take a look at the errors later today.

@schlessera

This comment has been minimized.

Show comment
Hide comment
@schlessera

schlessera Apr 4, 2018

Member

@marksabbath Are you still up for working on this command?

Quick note about the PR: An unrelated test now fails because you changed surrounding whitespace that is unrelated to your code change. Please make sure your editor does not introduce unwanted changes, to keep the PR clean and targeted.

Member

schlessera commented Apr 4, 2018

@marksabbath Are you still up for working on this command?

Quick note about the PR: An unrelated test now fails because you changed surrounding whitespace that is unrelated to your code change. Please make sure your editor does not introduce unwanted changes, to keep the PR clean and targeted.

@marksabbath

This comment has been minimized.

Show comment
Hide comment
@marksabbath

marksabbath Apr 4, 2018

Contributor

Yes @schlessera working on it BTW. Planning to finish that up by today.

Contributor

marksabbath commented Apr 4, 2018

Yes @schlessera working on it BTW. Planning to finish that up by today.

@marksabbath

This comment has been minimized.

Show comment
Hide comment
@marksabbath

marksabbath Apr 4, 2018

Contributor

Hey, @schlessera it seems that 2 errors not related to my code are blocking this merge.

1 - WordPress 5.0 seems to have changed the tables on Multisite installs (see https://travis-ci.org/wp-cli/db-command/jobs/362222469);
2 - Composer running out of memory on PHP5.3 (see https://travis-ci.org/wp-cli/db-command/jobs/362222470).

Should I update the tests of wp db tables (maybe using --scope=old) on multisite's test?
How could I get rid of #2?

Contributor

marksabbath commented Apr 4, 2018

Hey, @schlessera it seems that 2 errors not related to my code are blocking this merge.

1 - WordPress 5.0 seems to have changed the tables on Multisite installs (see https://travis-ci.org/wp-cli/db-command/jobs/362222469);
2 - Composer running out of memory on PHP5.3 (see https://travis-ci.org/wp-cli/db-command/jobs/362222470).

Should I update the tests of wp db tables (maybe using --scope=old) on multisite's test?
How could I get rid of #2?

@schlessera

This comment has been minimized.

Show comment
Hide comment
@schlessera

schlessera Apr 5, 2018

Member

@marksabbath Both issues should be resolved. If you merge latest master, tests should pass.

Member

schlessera commented Apr 5, 2018

@marksabbath Both issues should be resolved. If you merge latest master, tests should pass.

@marksabbath

This comment has been minimized.

Show comment
Hide comment
@marksabbath

marksabbath Apr 5, 2018

Contributor

Done @schlessera all good now! Thanks man!

Contributor

marksabbath commented Apr 5, 2018

Done @schlessera all good now! Thanks man!

@marksabbath

This comment has been minimized.

Show comment
Hide comment
@marksabbath

marksabbath Apr 23, 2018

Contributor

Anything else we would need to do to move this forward @schlessera ?

Contributor

marksabbath commented Apr 23, 2018

Anything else we would need to do to move this forward @schlessera ?

schlessera added some commits May 8, 2018

@schlessera

This comment has been minimized.

Show comment
Hide comment
@schlessera

schlessera May 8, 2018

Member

Thanks for the pull request, @marksabbath, and sorry for the wait. I did some minor changes, and this is good to be merged now.

Member

schlessera commented May 8, 2018

Thanks for the pull request, @marksabbath, and sorry for the wait. I did some minor changes, and this is good to be merged now.

@schlessera schlessera added this to the 1.3.4 milestone May 8, 2018

@schlessera schlessera merged commit ce8c51a into wp-cli:master May 8, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@schlessera schlessera changed the title from wp db clean implemented. to Add `wp db clean` command May 8, 2018

@marksabbath

This comment has been minimized.

Show comment
Hide comment
@marksabbath

marksabbath Jun 14, 2018

Contributor

This should resolve #92

Contributor

marksabbath commented Jun 14, 2018

This should resolve #92

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment