New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tests for 47. Allow for leading slashes in .distignore #58
Tests for 47. Allow for leading slashes in .distignore #58
Conversation
Working for zip Not quite working for tar The tar command is correct and works when I run it on the command line, but the tests are failing to exclude the file properly.
Tests are now passing on MacOS but not on GitHub Actions. The problem was that PHP's I've added a function to permit exceptions in I'll have to set up Ubuntu locally and run the tests there. I'll use nektos/act. |
Working for zip Not quite working for tar The tar command is correct and works when I run it on the command line, but the tests are failing to exclude the file properly.
a23834b
to
a1f922b
Compare
1. It seems `sys_get_temp_dir()` was being shared across multiple tests, so files already existed when subsequent tests were run. 2. Looks like the "no distignore file is present" test was failing after wp-cli#56 was merged.
…m/BrianHenryIE/dist-archive-command into anchor-distignore-entries-to-root
It seems There's a new test failure now! I have a feeling #59 will solve it. I'll work on the PR now. |
Ship #61 |
Example project:
with example
.distignore
:Should archive:
This is working for
zip
.The tests are failing for
tar
, but when I echo the tar command that is being used and manually cd to the directory and paste and run it, it works.Could someone please take a look and see if they can make sense of why it's not working? I'm guessing it's related to the current working directory being somehow affected inside
WP_CLI::launch()
.@markjaquith