New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

`wp user import-csv` to be able to import CSV from STDIN #100

Merged
merged 2 commits into from Oct 7, 2017

Conversation

3 participants
@miya0001
Member

miya0001 commented Oct 7, 2017

Fixes #96

miya0001 added some commits Oct 6, 2017

@miya0001 miya0001 changed the title from Patch 96 to `wp user import-csv` to be able to import CSV from STDIN Oct 7, 2017

@miya0001 miya0001 requested a review from wp-cli/committers Oct 7, 2017

@danielbachhuber danielbachhuber added this to the 1.1.1 milestone Oct 7, 2017

@danielbachhuber danielbachhuber merged commit dfedb1e into master Oct 7, 2017

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@danielbachhuber danielbachhuber deleted the patch-96 branch Oct 7, 2017

@gitlost

This comment has been minimized.

Show comment
Hide comment
@gitlost

gitlost Oct 7, 2017

Contributor

A small thing I noticed is that the second has_stdin() check should be removed from the if ( '-' === $filename statement before the loop.

Contributor

gitlost commented Oct 7, 2017

A small thing I noticed is that the second has_stdin() check should be removed from the if ( '-' === $filename statement before the loop.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment