Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add wp site meta sub-command #159

Merged
merged 41 commits into from May 28, 2018

Conversation

4 participants
@spacedmonkey
Copy link
Contributor

spacedmonkey commented Mar 22, 2018

Add the wp site meta sub-command, with tests.

This one is going to be hard to test and might be merge after 5.0.0 is released.

fixes #158

@@ -32,9 +32,6 @@
if ( !is_multisite() ) {
WP_CLI::error( 'This is not a multisite installation.' );
}
if ( \WP_CLI\Utils\wp_version_compare( '5.0', '<' ) ) {
WP_CLI::error( "Requires WordPress 5.0 or greater." );

This comment has been minimized.

@schlessera

schlessera Mar 25, 2018

Member

You'd still need to error out if the WordPress version is not the correct one, i.e. 5.0.

However, you should replace the \WP_CLI\Utils\wp_version_compare( '5.0', '<' ) with the function_exists('is_site_meta_supported') check.

@spacedmonkey spacedmonkey force-pushed the spacedmonkey:master branch from 9931c7a to a26f261 Apr 14, 2018

danielbachhuber and others added some commits Apr 14, 2018

sagar.nasit@rtcamp.com
Jonny Harris
Jonny Harris
Jonny Harris
Jonny Harris

schlessera and others added some commits Apr 17, 2018

Jonny Harris
Fix the fixes
We need to fix the tests in such a way that they don't break for everything that is not `trunk`, of course.
Merge pull request #177 from wp-cli/176-fix-tests-privacy-policy-page
Fix tests after Core's introduction of a default "Privacy Policy" page
Merge pull request #173 from wp-cli/170-remove-create
Remove duplicative `--user_email=<user-email>` argument

sagar.nasit@rtcamp.com and others added some commits Apr 21, 2018

sagar.nasit@rtcamp.com
Jonny Harris
sagar.nasit@rtcamp.com
Merge pull request #154 from sagarnasit/master
Add `--from-post=<post_id>` flag to create duplicate posts
Merge pull request #174 from spacedmonkey/functions-meta
Abstract meta CRUD into methods
@spacedmonkey

This comment has been minimized.

Copy link
Contributor Author

spacedmonkey commented May 17, 2018

Now that #174 is merged, I have updated the PR, with overrides that use the site_meta functions.

@schlessera Can you take a look at this PR again.

Quick note, I have rebased my branch, so I could make this change, it has a lot of commit from master in this branch. Sorry about this.

@schlessera schlessera merged commit bf540e2 into wp-cli:master May 28, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@schlessera schlessera added this to the 1.3.0 milestone May 28, 2018

@schlessera

This comment has been minimized.

Copy link
Member

schlessera commented May 28, 2018

Thanks for the PR, @spacedmonkey !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.
You signed in with another tab or window. Reload to refresh your session. You signed out in another tab or window. Reload to refresh your session.