Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
Abstract meta CRUD into methods #174
Apr 16, 2018
I have added some basic comments to this. @schlessera let me know if you want me to change them, I am not great for writing comments. Otherwise, I am happy with the PR as it is. Don't think there needs more work on it.
This PR needs to be merged before, #159 as that PR will need to changed, to implement changes in this PR.
The tests seem to be failing on trunk, but I think that is unreleated to my change...
@spacedmonkey I actually meant for you to add
@spacedmonkey I pushed a change to add full docblocks to the methods.
While doing so, I noticed that the functions
Reading through the docs, it seems to me that this argument does not make any sense in our current context, and would be more useful for a separate command.
How do you suggest we proceed?
Thanks for the feedback @schlessera !
I have remove the