New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix tests after Core's introduction of a default "Privacy Policy" page #177

Merged
merged 4 commits into from Apr 17, 2018

Conversation

2 participants
@schlessera
Member

schlessera commented Apr 17, 2018

Fixes #176

schlessera added some commits Apr 17, 2018

@schlessera schlessera added this to the 1.3.0 milestone Apr 17, 2018

@schlessera schlessera requested a review from wp-cli/committers Apr 17, 2018

Fix the fixes
We need to fix the tests in such a way that they don't break for everything that is not `trunk`, of course.
@danielbachhuber

This comment has been minimized.

Show comment
Hide comment
@danielbachhuber

danielbachhuber Apr 17, 2018

Member

@schlessera Looks like this is still failing? Do the tests need to be dynamic based on WP version?

Member

danielbachhuber commented Apr 17, 2018

@schlessera Looks like this is still failing? Do the tests need to be dynamic based on WP version?

@schlessera

This comment has been minimized.

Show comment
Hide comment
@schlessera

schlessera Apr 17, 2018

Member

@danielbachhuber Yes, it is. I quickly realized that I only fixed it for trunk, but we're not dealing with a normal web project targeting a single platform here. So I modified the fix, but lost the internet connection when the plane took off before being able to push.

It should hopefully work on non-trunk as well now. :)

Member

schlessera commented Apr 17, 2018

@danielbachhuber Yes, it is. I quickly realized that I only fixed it for trunk, but we're not dealing with a normal web project targeting a single platform here. So I modified the fix, but lost the internet connection when the plane took off before being able to push.

It should hopefully work on non-trunk as well now. :)

@danielbachhuber danielbachhuber merged commit 92c6937 into master Apr 17, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@danielbachhuber danielbachhuber deleted the 176-fix-tests-privacy-policy-page branch Apr 17, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment