New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace 'install' to 'installation.' #187

Merged
merged 2 commits into from Jun 5, 2018

Conversation

2 participants
@sasagar
Contributor

sasagar commented Jun 3, 2018

To make the words for correct usage.
For issue of wp-cli #4541 ( wp-cli/wp-cli#4541 )

Replace 'install' to 'installation.'
To make the words for correct usage.
@schlessera

This comment has been minimized.

Show comment
Hide comment
@schlessera

schlessera Jun 3, 2018

Member

Thanks for the PR, @sasagar !

When making changes to the code documentation, you also need to re-run the wp scaffold package-readme tool so that the README.md file is updated.

To do this, you need to first ensure that you have installed the optional wp-cli/scaffold-package-command package (you might need to bump PHP memory_limit to run this):

wp package install wp-cli/scaffold-package-command

Then, from within the folder of this entity-command package, you can run the following command to update the README.md file:

wp scaffold package-readme . --force
Member

schlessera commented Jun 3, 2018

Thanks for the PR, @sasagar !

When making changes to the code documentation, you also need to re-run the wp scaffold package-readme tool so that the README.md file is updated.

To do this, you need to first ensure that you have installed the optional wp-cli/scaffold-package-command package (you might need to bump PHP memory_limit to run this):

wp package install wp-cli/scaffold-package-command

Then, from within the folder of this entity-command package, you can run the following command to update the README.md file:

wp scaffold package-readme . --force
@sasagar

This comment has been minimized.

Show comment
Hide comment
@sasagar

sasagar Jun 3, 2018

Contributor

@schlessera
Thanks for your advice!
I re-commit the new version, I hope it works.

Thanks for your support today. (also notify the end of the contributor day.)

Contributor

sasagar commented Jun 3, 2018

@schlessera
Thanks for your advice!
I re-commit the new version, I hope it works.

Thanks for your support today. (also notify the end of the contributor day.)

@schlessera schlessera added this to the 1.3.1 milestone Jun 5, 2018

@schlessera schlessera merged commit 943fd52 into wp-cli:master Jun 5, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@schlessera

This comment has been minimized.

Show comment
Hide comment
@schlessera

schlessera Jun 5, 2018

Member

Thanks for the PR, @sasagar !

Member

schlessera commented Jun 5, 2018

Thanks for the PR, @sasagar !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment