New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support emails in user_login field #21

Merged
merged 2 commits into from Jun 29, 2017

Conversation

2 participants
@soulseekah
Contributor

soulseekah commented Jun 29, 2017

Logins can be set to e-mails, and are often set this way. This is fine,
until the user changes the e-mail (logins can't be changed). What
happens then? wp user get doesn't find the user by login, because if
the login is an e-mail it shorts to checking only the user_email field.

Rectify this. Tests included.

soulseekah and others added some commits Jun 29, 2017

Support emails in user_login field
Logins can be set to e-mails, and are often set this way. This is fine,
until the user changes the e-mail (logins can't be changed). What
happens then? `wp user get` doesn't find the user by login, because if
the login is an e-mail it shorts to checking only the user_email field.

Rectify this. Tests included.

@danielbachhuber danielbachhuber added this to the 1.0.3 milestone Jun 29, 2017

@danielbachhuber

Looks good 👍 Made some WPCS changes too

@soulseekah

This comment has been minimized.

Show comment
Hide comment
@soulseekah

soulseekah Jun 29, 2017

Contributor

Thanks :)

Contributor

soulseekah commented Jun 29, 2017

Thanks :)

@danielbachhuber danielbachhuber merged commit 5f92520 into wp-cli:master Jun 29, 2017

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment