Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reset option value to default for privacy policy on site empty #236

Merged
merged 3 commits into from Mar 4, 2019

Conversation

@thrijith
Copy link
Member

commented Feb 28, 2019

@danielbachhuber
Copy link
Member

left a comment

Hi @thrijith! Can you include a feature test for this too?

@thrijith

This comment has been minimized.

Copy link
Member Author

commented Mar 1, 2019

Hi @danielbachhuber, I have added a test in an existing scenario. LMK if it's ok.

Then STDOUT should be:
"""
0
"""

This comment has been minimized.

Copy link
@danielbachhuber

danielbachhuber Mar 1, 2019

Member

Can we also include a test that makes sure there's a non-zero value before wp site empty is run?

This comment has been minimized.

Copy link
@thrijith

thrijith Mar 1, 2019

Author Member

I am not sure how to do that, should I create a dummy page and assign it as privacy page?

This comment has been minimized.

Copy link
@danielbachhuber

danielbachhuber Mar 1, 2019

Member

should I create a dummy page and assign it as privacy page?

Yes, this would be fine.

@danielbachhuber danielbachhuber self-requested a review Mar 4, 2019

@danielbachhuber
Copy link
Member

left a comment

👍 Thanks @thrijith

@danielbachhuber danielbachhuber added this to the 2.0.3 milestone Mar 4, 2019

@danielbachhuber danielbachhuber merged commit af461e3 into wp-cli:master Mar 4, 2019

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@thrijith thrijith deleted the thrijith:feature/update-site-empty branch Mar 4, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
You can’t perform that action at this time.