Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix logic error in presence of 'site meta' check #244

Merged
merged 1 commit into from Apr 1, 2019

Conversation

@musicaljoeker
Copy link
Contributor

commented Mar 31, 2019

WordPress sites prior to 5.1 do not support calls to the 'site meta' command. Instead of throwing a fatal error, WP CLI now errors gracefully saying that the table is not supported.

Fixes #235

@musicaljoeker musicaljoeker requested a review from wp-cli/committers as a code owner Mar 31, 2019

@schlessera schlessera changed the title Resolves issue 235 where error wasn't being thrown if 'site meta' isn't supported Fix logic error in presence of 'site meta' check Apr 1, 2019

@schlessera schlessera added this to the 2.0.3 milestone Apr 1, 2019

@schlessera schlessera merged commit 4f4992f into wp-cli:master Apr 1, 2019

2 checks passed

DEP All dependencies are resolved
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@schlessera

This comment has been minimized.

Copy link
Member

commented Apr 1, 2019

Thanks for the PR, @musicaljoeker !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
You can’t perform that action at this time.