Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow deleting multiple options at once #247

Merged
merged 2 commits into from Apr 20, 2019

Conversation

@Sidsector9
Copy link
Member

commented Apr 6, 2019

Related #220

Adds the feature to delete multiple options at once by running a foreach loop on the arguments.

@Sidsector9 Sidsector9 requested a review from wp-cli/committers as a code owner Apr 6, 2019

@Sidsector9 Sidsector9 force-pushed the Sidsector9:feat/220 branch from 7a4634e to 716c154 Apr 7, 2019

@thrijith
Copy link
Member

left a comment

Minor changes.

src/Option_Command.php Outdated Show resolved Hide resolved
src/Option_Command.php Outdated Show resolved Hide resolved
features/option.feature Outdated Show resolved Hide resolved

@Sidsector9 Sidsector9 force-pushed the Sidsector9:feat/220 branch from 716c154 to 5590d1b Apr 7, 2019

@thrijith thrijith changed the title feat: delete multiple options at once Allow deleting multiple options at once Apr 18, 2019

@thrijith
Copy link
Member

left a comment

LGTM, @schlessera Could you please take a look? Thanks.

@schlessera
Copy link
Member

left a comment

Only a minor nitpick, I always prefer to have curly braces around variable substitution, as that habit makes broken substitutions impossible (where the variable name is immediately followed by other text) and is visually clearer.

src/Option_Command.php Outdated Show resolved Hide resolved
src/Option_Command.php Outdated Show resolved Hide resolved

@schlessera schlessera added this to the 2.0.3 milestone Apr 20, 2019

@schlessera schlessera merged commit 5447cd3 into wp-cli:master Apr 20, 2019

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@schlessera

This comment has been minimized.

Copy link
Member

commented Apr 20, 2019

Thanks for the PR, @Sidsector9 !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants
You can’t perform that action at this time.