Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix minor PHPCS violation #273

Merged
merged 1 commit into from Nov 5, 2019
Merged

Fix minor PHPCS violation #273

merged 1 commit into from Nov 5, 2019

Conversation

@thrijith
Copy link
Member

thrijith commented Nov 4, 2019

Fix violation causing build failure here https://travis-ci.org/wp-cli/entity-command/jobs/607188276#L587-L595

Got this when I merged #266, not sure why it was not reported while WP_CLI_CS was implemented.

@thrijith thrijith requested a review from wp-cli/committers as a code owner Nov 4, 2019
@thrijith

This comment has been minimized.

Copy link
Member Author

thrijith commented Nov 5, 2019

@schlessera is the job failure due to the declaration of feedback in https://github.com/wp-cli/wp-cli/blob/904f35f541697ac9c939c42b6742b99c32015d5b/php/WP_CLI/Compat/Min_PHP_5_6/FeedbackMethodTrait.php#L12 which accepts 2 params?

Also $args_array and $arg in the function doesn't seem to be used

public function feedback( $string, ...$args ) { // phpcs:ignore PHPCompatibility.LanguageConstructs.NewLanguageConstructs.t_ellipsisFound
	$args_array = [];
	foreach ( $args as $arg ) {
		$args_array[] = $args;
	}

	$this->process_feedback( $string, $args );
}
@schlessera

This comment has been minimized.

Copy link
Member

schlessera commented Nov 5, 2019

@thrijith This was fixed in wp-cli/wp-cli#5283

We could move to dev-master on wp-cli/wp-cli to get the tests to pass, but I'm just merging this one as-is for now.

@schlessera schlessera added the bug label Nov 5, 2019
@schlessera schlessera added this to the 2.0.7 milestone Nov 5, 2019
@schlessera schlessera merged commit 86baa1a into master Nov 5, 2019
1 of 2 checks passed
1 of 2 checks passed
continuous-integration/travis-ci/pr The Travis CI build failed
Details
DEP All dependencies are resolved
@schlessera schlessera deleted the fix/sniff-vioaltion branch Nov 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
You can’t perform that action at this time.