New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added support for mature and public status types #63

Merged
merged 7 commits into from Aug 25, 2017

Conversation

@Sidsector9
Member

Sidsector9 commented Aug 24, 2017

See #51

@Sidsector9 Sidsector9 self-assigned this Aug 24, 2017

@miya0001

This comment has been minimized.

Show comment
Hide comment
@miya0001

miya0001 Aug 24, 2017

Member

Related #51

Member

miya0001 commented Aug 24, 2017

Related #51

@miya0001

This comment has been minimized.

Show comment
Hide comment
@miya0001

miya0001 Aug 24, 2017

Member

Can you add behat tests?

Member

miya0001 commented Aug 24, 2017

Can you add behat tests?

@Sidsector9

This comment has been minimized.

Show comment
Hide comment
@Sidsector9

Sidsector9 Aug 24, 2017

Member

@miya0001 almost done, will push the tests soon

Member

Sidsector9 commented Aug 24, 2017

@miya0001 almost done, will push the tests soon

@Sidsector9 Sidsector9 requested a review from miya0001 Aug 24, 2017

@miya0001 miya0001 requested review from wp-cli/committers and removed request for miya0001 Aug 24, 2017

@miya0001

It looks good to me. 😄

Show outdated Hide outdated src/Site_Command.php Outdated
Show outdated Hide outdated src/Site_Command.php Outdated
Show outdated Hide outdated src/Site_Command.php Outdated

@danielbachhuber danielbachhuber changed the title from GH#51 Added support for mature and public status types to Added support for mature and public status types Aug 24, 2017

@danielbachhuber

This comment has been minimized.

Show comment
Hide comment
@danielbachhuber

danielbachhuber Aug 24, 2017

Member

@Sidsector9 As a point of procedure, if you include the issue in the body of the pull request (see screenshot) then the pull request will correctly appear in the history of the issue:

image

image

Member

danielbachhuber commented Aug 24, 2017

@Sidsector9 As a point of procedure, if you include the issue in the body of the pull request (see screenshot) then the pull request will correctly appear in the history of the issue:

image

image

@Sidsector9

This comment has been minimized.

Show comment
Hide comment
@Sidsector9

Sidsector9 Aug 25, 2017

Member

@danielbachhuber The changes are done

Member

Sidsector9 commented Aug 25, 2017

@danielbachhuber The changes are done

@danielbachhuber danielbachhuber merged commit eceebcd into wp-cli:master Aug 25, 2017

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment