New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error and prevent deleting root site #73

Merged
merged 5 commits into from Sep 15, 2017

Conversation

@Sidsector9
Member

Sidsector9 commented Aug 31, 2017

Fixes #66

@Sidsector9 Sidsector9 self-assigned this Aug 31, 2017

@Sidsector9 Sidsector9 requested a review from miya0001 Aug 31, 2017

@Sidsector9 Sidsector9 requested a review from danielbachhuber Aug 31, 2017

Show outdated Hide outdated src/Site_Command.php Outdated
Show outdated Hide outdated src/Site_Command.php Outdated
@miya0001

I guess we need more tests, for example:

When I run `wp site delete 1 --delete-root`
@Sidsector9

This comment has been minimized.

Show comment
Hide comment
@Sidsector9

Sidsector9 Sep 11, 2017

Member

Related to #66 (comment) and #66 (comment)
I have made the necessary modifications.

Member

Sidsector9 commented Sep 11, 2017

Related to #66 (comment) and #66 (comment)
I have made the necessary modifications.

@Sidsector9 Sidsector9 changed the title from Added flag --delete-root to Added error on deleting root blog Sep 11, 2017

Show outdated Hide outdated src/Site_Command.php Outdated

@danielbachhuber danielbachhuber removed the request for review from schlessera Sep 15, 2017

@danielbachhuber danielbachhuber changed the title from Added error on deleting root blog to Error and prevent deleting root site Sep 15, 2017

@danielbachhuber danielbachhuber merged commit 3ddbd81 into wp-cli:master Sep 15, 2017

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment