New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adjust user tests 'spamed' -> 'spammed'. #90

Merged
merged 2 commits into from Sep 17, 2017

Conversation

2 participants
@gitlost
Contributor

gitlost commented Sep 16, 2017

Issue #89

Related PRs wp-cli/wp-cli#4351 and #74

Adjusts user spam tests past tense spamed -> spammed.

@schlessera

What about the changes to .gitignore and composer.json ?

@gitlost

This comment has been minimized.

Show comment
Hide comment
@gitlost

gitlost Sep 16, 2017

Contributor

Sorry the .gitignore change was me trying to sneak in vi friendliness. The composer.json change I thought was necessary but forgot about the composer require wp-cli/wp-cli:dev-master in .travis.yml. I've removed both.

Contributor

gitlost commented Sep 16, 2017

Sorry the .gitignore change was me trying to sneak in vi friendliness. The composer.json change I thought was necessary but forgot about the composer require wp-cli/wp-cli:dev-master in .travis.yml. I've removed both.

@schlessera

This comment has been minimized.

Show comment
Hide comment
@schlessera

schlessera Sep 17, 2017

Member

For stuff like the vi files, you should put rules into your global git ignore file instead: https://help.github.com/articles/ignoring-files/#create-a-global-gitignore

Just do this once, and you'll never have to worry about them again.

Member

schlessera commented Sep 17, 2017

For stuff like the vi files, you should put rules into your global git ignore file instead: https://help.github.com/articles/ignoring-files/#create-a-global-gitignore

Just do this once, and you'll never have to worry about them again.

@schlessera schlessera merged commit 67d1bfc into master Sep 17, 2017

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@schlessera schlessera deleted the issue_89 branch Sep 17, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment