New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support eval-file from stdin (implementation for #19) #21

Merged
merged 4 commits into from Feb 21, 2018

Conversation

2 participants
@pjeby
Contributor

pjeby commented Feb 17, 2018

Per issue #19, this PR implements the ability to wp eval-file code from php://stdin, using - for consistency with other wp-cli commands that take input from stdin.

Show outdated Hide outdated src/EvalFile_Command.php
Show outdated Hide outdated src/EvalFile_Command.php
Show outdated Hide outdated README.md
Show outdated Hide outdated src/EvalFile_Command.php
@schlessera

This comment has been minimized.

Show comment
Hide comment
@schlessera

schlessera Feb 20, 2018

Member

Hey @pjeby ,
Thanks for the pull request.
Everything's fine with the code, I just have a few small nitpicks regarding the form. As soon as you can push a change with the small details, this is good to be merged.

Member

schlessera commented Feb 20, 2018

Hey @pjeby ,
Thanks for the pull request.
Everything's fine with the code, I just have a few small nitpicks regarding the form. As soon as you can push a change with the small details, this is good to be merged.

@pjeby

This comment has been minimized.

Show comment
Hide comment
@pjeby

pjeby Feb 20, 2018

Contributor

Done.

Contributor

pjeby commented Feb 20, 2018

Done.

@schlessera schlessera merged commit 7d81db1 into wp-cli:master Feb 21, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@schlessera schlessera added this to the 1.0.6 milestone Feb 21, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment