Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reuse `File_Writer` for `STDOUT` support #60

Merged
merged 2 commits into from Jul 15, 2019

Conversation

@drzraf
Copy link
Contributor

commented Jul 11, 2019

In #9 (bbcc22a), we introduced Stdout_Writer in order to fwrite(STDOUT).

It's more elegant to reuse the File_Writer() and pass php://output (although we don't have yet a use-case for its output-buffering support)

In #9 (bbcc22a), we introduced Stdout_Writer in order to fwrite(STDOUT).
It's more elegant to reuse the File_Writer() and pass php://output
 (although we don't have yet a use-case for its output-buffering support)

@drzraf drzraf requested a review from wp-cli/committers as a code owner Jul 11, 2019

src/Export_Command.php Outdated Show resolved Hide resolved

@schlessera schlessera added this to the 2.0.3 milestone Jul 15, 2019

@schlessera schlessera changed the title Reuse File_Writer for stdout support Reuse `File_Writer` for `STDOUT` support Jul 15, 2019

@schlessera schlessera merged commit 519fdf2 into wp-cli:master Jul 15, 2019

2 checks passed

DEP All dependencies are resolved
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants
You can’t perform that action at this time.