New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add `--all` flag to `plugin delete` #103

Merged
merged 3 commits into from Jul 31, 2018

Conversation

2 participants
@svenkaptein
Contributor

svenkaptein commented Jun 14, 2018

My first contribution so hopefully everything is OK.
Addressing issue #88

Show outdated Hide outdated src/Plugin_Command.php
@schlessera

This comment has been minimized.

Show comment
Hide comment
@schlessera

schlessera Jul 31, 2018

Member

@svenkaptein Thanks for the pull request, and sorry for dropping the ball on this.

The tests are currently broken, but a simple removal of superfluous code as hinted at in the review should fix them. As soon as they pass, this is good to be merged.

Member

schlessera commented Jul 31, 2018

@svenkaptein Thanks for the pull request, and sorry for dropping the ball on this.

The tests are currently broken, but a simple removal of superfluous code as hinted at in the review should fix them. As soon as they pass, this is good to be merged.

@schlessera

This comment has been minimized.

Show comment
Hide comment
@schlessera

schlessera Jul 31, 2018

Member

I'm making the required change myself to add this to the release I'm tagging...

Member

schlessera commented Jul 31, 2018

I'm making the required change myself to add this to the release I'm tagging...

@schlessera schlessera added this to the 1.2.2 milestone Jul 31, 2018

@schlessera schlessera merged commit 18f1036 into wp-cli:master Jul 31, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@schlessera schlessera changed the title from Add --all flag to plugin delete to Add `--all` flag to `plugin delete` Jul 31, 2018

@schlessera

This comment has been minimized.

Show comment
Hide comment
@schlessera

schlessera Jul 31, 2018

Member

Thanks for the pull-request, @svenkaptein !

Member

schlessera commented Jul 31, 2018

Thanks for the pull-request, @svenkaptein !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment