New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Search: Add plugin or theme's URL on wordpress.org #108

Merged
merged 3 commits into from Jul 26, 2018

Conversation

2 participants
@GaryJones
Contributor

GaryJones commented Jul 19, 2018

After the plugin_api() or theme_api() call is made, update the results with the generated URL for wordpress.org, made up of a hard-coded domain name, the plural of the item type, and the item's slug.

Fixes #94.

Show outdated Hide outdated src/Plugin_Command.php
Show outdated Hide outdated src/WP_CLI/CommandWithUpgrade.php
Search: Add plugin or theme's URL on wordpress.org
After the plugin_api() or theme_api() call is made, update the results with the generated URL for wordpress.org, made up of a hard-coded domain name, the plural of the item type, and the item's slug.

Fixes #94.
@schlessera

This comment has been minimized.

Show comment
Hide comment
@schlessera

schlessera Jul 20, 2018

Member

This currently fails on WP trunk: https://travis-ci.org/wp-cli/extension-command/jobs/406130240#L665-L704

I assume the plugins_api() function has changed.

Member

schlessera commented Jul 20, 2018

This currently fails on WP trunk: https://travis-ci.org/wp-cli/extension-command/jobs/406130240#L665-L704

I assume the plugins_api() function has changed.

@GaryJones

This comment has been minimized.

Show comment
Hide comment
@GaryJones

GaryJones Jul 20, 2018

Contributor

This currently fails on WP trunk

Trying a workaround first.

Contributor

GaryJones commented Jul 20, 2018

This currently fails on WP trunk

Trying a workaround first.

@schlessera schlessera modified the milestones: 1.2.1, 1.2.2 Jul 25, 2018

@schlessera schlessera merged commit faa452b into wp-cli:master Jul 26, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@schlessera

This comment has been minimized.

Show comment
Hide comment
@schlessera

schlessera Jul 26, 2018

Member

Thanks for the pull request, @GaryJones !

Member

schlessera commented Jul 26, 2018

Thanks for the pull request, @GaryJones !

@GaryJones GaryJones deleted the GaryJones:feature/94-url branch Jul 27, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment