New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Throw error in theme fetcher on non-lowercase slugs #126

Merged
merged 2 commits into from Aug 23, 2018

Conversation

1 participant
@schlessera
Member

schlessera commented Aug 23, 2018

Fixes #121

This is a breaking change, in that the error output might change for some rare edge cases where previously the expected result would have been produced by sheer coincidence.

Generally, though, this just resolves a bug and should make behavior more consistent and reliable now.

@schlessera schlessera merged commit 49273af into master Aug 23, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@schlessera schlessera deleted the 121-slug-case-mismatch branch Aug 23, 2018

@schlessera schlessera referenced this pull request Sep 5, 2018

Open

Revert #126 #128

16dyui added a commit to 16dyui/extension-command that referenced this pull request Sep 14, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment