New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Failed plugin updates now throw errors #143

Merged
merged 6 commits into from Dec 12, 2018

Conversation

2 participants
@austinginder
Copy link
Contributor

austinginder commented Dec 9, 2018

Resolve issue #90. This checks for a null response from bulk_upgrade and assumes a plugin update did not occur. That may include more errors than intended as plugin update errors are not included in response. Refer to https://developer.wordpress.org/reference/classes/plugin_upgrader/.

@schlessera schlessera added this to the 2.0.2 milestone Dec 9, 2018

austinginder and others added some commits Dec 9, 2018

👌 IMPROVE: Update src/WP_CLI/CommandWithUpgrade.php
Co-Authored-By: austinginder <austinginder@gmail.com>
Merge branch 'fix-90-plugin-update-reporting' of github.com:austingin…
…der/extension-command into fix-90-plugin-update-reporting

schlessera and others added some commits Dec 12, 2018

Update features/plugin-update.feature
Co-Authored-By: austinginder <austinginder@gmail.com>

@schlessera schlessera merged commit 5c7fbd9 into wp-cli:master Dec 12, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@schlessera

This comment has been minimized.

Copy link
Member

schlessera commented Dec 12, 2018

Thanks for the PR, @austinginder !

@schlessera schlessera changed the title 🐛 FIX: Failed plugin updates not throwing errors Failed plugin updates now throw errors Dec 12, 2018

@austinginder

This comment has been minimized.

Copy link
Contributor

austinginder commented Dec 12, 2018

@schlessera Sure thing and thanks for helping me work through the Behat test.

@schlessera schlessera modified the milestones: 2.0.2, 2.0.3 Dec 17, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment