Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add the `--page` parameter to the `theme search` command #167

Merged
merged 3 commits into from Apr 21, 2019

Conversation

@amieiro
Copy link
Contributor

commented Apr 17, 2019

Fix the #166 bug: the "wp theme search" command has not the "page" option

amieiro added some commits Apr 16, 2019

Add the --page parameter to the docblock of the theme search command
Fix the #166 bug:
the "wp theme search" command has not the "page" option

@amieiro amieiro requested a review from wp-cli/committers as a code owner Apr 17, 2019

@schlessera
Copy link
Member

left a comment

Hehe, looks like our README.md was not fully up-to-date... ;)

The PR looks good except for the indentation in the docblock. Please use tabs there.

src/Theme_Command.php Outdated Show resolved Hide resolved

@schlessera schlessera changed the title Add the --page parameter to the theme search command Add the `--page` parameter to the `theme search` command Apr 17, 2019

@schlessera schlessera merged commit c8556c1 into wp-cli:master Apr 21, 2019

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@schlessera

This comment has been minimized.

Copy link
Member

commented Apr 21, 2019

Thanks for the PR, @amieiro !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
You can’t perform that action at this time.