New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Don't report an error when 5 out of 5 plugins were updated #338
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, @akirk !
It'd be great to have a feature
test for this change. Would you be open to putting one together?
Here's an introduction to Behat tests: https://make.wordpress.org/cli/handbook/contributions/pull-requests/#functional-tests
I've added a behat test and fixed the phpcs, could you kick off the workflow again? Thanks! |
@akirk Yep! Looks like the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work on this! 🙌
@akirk Any ideas what this last failure might be? |
Struggling to understand the failure, it runs fine for me locally.
|
Oh it fails on PHP 5.6. |
@akirk It also looks like it's been failing on master for a while: https://github.com/wp-cli/extension-command/actions/runs/3338955722/jobs/5527290587 Thanks again for your work on this! |
Currently, if you've got (unreleased) plugins with an unexpected version they are skipped but this skipping is recorded in a wrong way resulting in a summary output that says
Error: Only updated 5 of 5 plugins.
Before
After