New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't attempt to rename ZIPs coming from a GitHub archive release/tag #45

Merged
merged 5 commits into from Sep 26, 2017

Conversation

4 participants
@ryotsun
Contributor

ryotsun commented Sep 20, 2017

Fixed Issue #35

I've tried fixing against this issue.
Please review PR and give me some advice.

Thank you.

@ryotsun

This comment has been minimized.

Show comment
Hide comment
@ryotsun
Contributor

ryotsun commented Sep 20, 2017

@danielbachhuber

Thanks @ryotsun. Can you include a test for this change?

@ryotsun

This comment has been minimized.

Show comment
Hide comment
@ryotsun

ryotsun Sep 20, 2017

Contributor

@danielbachhuber Sure. Sorry for missing.
I'm working on it. 🙇

Contributor

ryotsun commented Sep 20, 2017

@danielbachhuber Sure. Sorry for missing.
I'm working on it. 🙇

@ryotsun

This comment has been minimized.

Show comment
Hide comment
@ryotsun

ryotsun Sep 20, 2017

Contributor

@danielbachhuber @miya0001
I wrote a test 👍

Btw, test fails every time on WP 3.7.11 even if there is no code changes (means in master branch).
Therefore, it might have no relevance to my changes.
Anyway, I tried testing for the following on my local env.

$ WP_VERSION=3.7.11 vendor/bin/behat features/plugin-update.feature 

but unfortunately, I encountered the same error.

Contributor

ryotsun commented Sep 20, 2017

@danielbachhuber @miya0001
I wrote a test 👍

Btw, test fails every time on WP 3.7.11 even if there is no code changes (means in master branch).
Therefore, it might have no relevance to my changes.
Anyway, I tried testing for the following on my local env.

$ WP_VERSION=3.7.11 vendor/bin/behat features/plugin-update.feature 

but unfortunately, I encountered the same error.

@miya0001

This comment has been minimized.

Show comment
Hide comment
@miya0001

miya0001 Sep 21, 2017

Member

Hi @danielbachhuber

I realized that the version number of the 3.7 should be 3.7.11 instead of 3.7 or 3.7.22?
https://codex.wordpress.org/WordPress_Versions

Member

miya0001 commented Sep 21, 2017

Hi @danielbachhuber

I realized that the version number of the 3.7 should be 3.7.11 instead of 3.7 or 3.7.22?
https://codex.wordpress.org/WordPress_Versions

@danielbachhuber

This comment has been minimized.

Show comment
Hide comment
@danielbachhuber

danielbachhuber Sep 21, 2017

Member

I realized that the version number of the 3.7 should be 3.7.11 instead of 3.7 or 3.7.22?

Could. I'm not sure what's causing the test failure off the top of my head though.

Member

danielbachhuber commented Sep 21, 2017

I realized that the version number of the 3.7 should be 3.7.11 instead of 3.7 or 3.7.22?

Could. I'm not sure what's causing the test failure off the top of my head though.

@miya0001

This comment has been minimized.

Show comment
Hide comment
@miya0001

miya0001 Sep 23, 2017

Member

@ryotsun
Please merge #49 to your PR if #49 will be merged.
Then tests will be passed. :)

Member

miya0001 commented Sep 23, 2017

@ryotsun
Please merge #49 to your PR if #49 will be merged.
Then tests will be passed. :)

@ryotsun

This comment has been minimized.

Show comment
Hide comment
@ryotsun

ryotsun Sep 25, 2017

Contributor

@danielbachhuber @miya0001
Hello,
finally, all checks have passed on Travis CI... 😄
Please check it again.

Contributor

ryotsun commented Sep 25, 2017

@danielbachhuber @miya0001
Hello,
finally, all checks have passed on Travis CI... 😄
Please check it again.

@miya0001

@ryotsun Thanks :)

The plugin used in the tests maintained by third-party.
Please change the URL to the following URL to prevent unexpected problem.
https://github.com/miya0001/example-plugin/archive/v0.1.0.zip

@schlessera

This comment has been minimized.

Show comment
Hide comment
@schlessera

schlessera Sep 26, 2017

Member

@miya0001 , @ryotsun : We now have a separate GitHub organization called wp-cli-test to contain stuff like the above example plugin, that should represent external packages.

Just let me know what it is you need, and I will add it to that test organization. @miya0001, should I add the above plugin as-is?

Member

schlessera commented Sep 26, 2017

@miya0001 , @ryotsun : We now have a separate GitHub organization called wp-cli-test to contain stuff like the above example plugin, that should represent external packages.

Just let me know what it is you need, and I will add it to that test organization. @miya0001, should I add the above plugin as-is?

@miya0001

This comment has been minimized.

Show comment
Hide comment
@miya0001

miya0001 Sep 26, 2017

Member

@schlessera

should I add the above plugin as-is?

Oh, yes please! 😊

Member

miya0001 commented Sep 26, 2017

@schlessera

should I add the above plugin as-is?

Oh, yes please! 😊

@schlessera

This comment has been minimized.

Show comment
Hide comment
@schlessera

schlessera Sep 26, 2017

Member

Will do and update here as soon as I got the required access. The org is brand new.

Member

schlessera commented Sep 26, 2017

Will do and update here as soon as I got the required access. The org is brand new.

@schlessera

This comment has been minimized.

Show comment
Hide comment
@schlessera
Member

schlessera commented Sep 26, 2017

@miya0001, @ryotsun : Here's the plugin you can use for testing: https://github.com/wp-cli-test/generic-example-plugin

@ryotsun

This comment has been minimized.

Show comment
Hide comment
@ryotsun

ryotsun Sep 26, 2017

Contributor

@miya0001 @schlessera
Thank you for your assistance.
I've updated plugin's path to the following as you said:
https://github.com/wp-cli-test/generic-example-plugin

Thank you.

Contributor

ryotsun commented Sep 26, 2017

@miya0001 @schlessera
Thank you for your assistance.
I've updated plugin's path to the following as you said:
https://github.com/wp-cli-test/generic-example-plugin

Thank you.

@miya0001

@ryotsun Thanks 😊

@danielbachhuber danielbachhuber changed the title from Fix incorrect plugin name. to Don't attempt to rename ZIPs coming from a GitHub archive release/tag Sep 26, 2017

@danielbachhuber danielbachhuber added this to the 1.1.3 milestone Sep 26, 2017

@danielbachhuber

This comment has been minimized.

Show comment
Hide comment
@danielbachhuber

danielbachhuber Sep 26, 2017

Member

Thanks for your work on this @ryotsun !

Member

danielbachhuber commented Sep 26, 2017

Thanks for your work on this @ryotsun !

@danielbachhuber danielbachhuber merged commit 5c9db74 into wp-cli:master Sep 26, 2017

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment