New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add --all flag for plugin uninstall command #84

Merged
merged 12 commits into from Feb 25, 2018

Conversation

3 participants
@BhargavBhandari90
Contributor

BhargavBhandari90 commented Feb 12, 2018

for #75

@BhargavBhandari90 BhargavBhandari90 changed the title from WIP: #75Add --all flag for plugin uninstall command to WIP: #75 Add --all flag for plugin uninstall command Feb 12, 2018

@BhargavBhandari90 BhargavBhandari90 changed the title from WIP: #75 Add --all flag for plugin uninstall command to Add --all flag for plugin uninstall command Feb 12, 2018

@BhargavBhandari90

This comment has been minimized.

Show comment
Hide comment
@BhargavBhandari90

BhargavBhandari90 Feb 12, 2018

Contributor

@schlessera @danielbachhuber

I think the test is not failing because of my changes.

It's showing error from features/plugin-install.feature and features/upgradables.feature which is not changed.

Contributor

BhargavBhandari90 commented Feb 12, 2018

@schlessera @danielbachhuber

I think the test is not failing because of my changes.

It's showing error from features/plugin-install.feature and features/upgradables.feature which is not changed.

Show outdated Hide outdated src/Plugin_Command.php
Show outdated Hide outdated features/plugin-uninstall.feature
Show outdated Hide outdated features/plugin-uninstall.feature
Show outdated Hide outdated features/plugin-uninstall.feature
Show outdated Hide outdated src/Plugin_Command.php
Show outdated Hide outdated src/Plugin_Command.php
Show outdated Hide outdated src/Plugin_Command.php
Show outdated Hide outdated src/Plugin_Command.php

@gitlost gitlost added this to the 1.1.10 milestone Feb 13, 2018

@gitlost

This comment has been minimized.

Show comment
Hide comment
@gitlost

gitlost Feb 13, 2018

Contributor

Ah, so you have to do your review comments in code order, not very second-thoughts friendly...

Contributor

gitlost commented Feb 13, 2018

Ah, so you have to do your review comments in code order, not very second-thoughts friendly...

@BhargavBhandari90

This comment has been minimized.

Show comment
Hide comment
@BhargavBhandari90

BhargavBhandari90 Feb 15, 2018

Contributor

@gitlost See this.
screen shot 2018-02-15 at 5 34 01 pm

Contributor

BhargavBhandari90 commented Feb 15, 2018

@gitlost See this.
screen shot 2018-02-15 at 5 34 01 pm

@schlessera

This comment has been minimized.

Show comment
Hide comment
@schlessera

schlessera Feb 15, 2018

Member

@BhargavBhandari90 When you run a test that expects an error to be thrown, like it is the case here, you need to use And I try ..., not And I run ....
run => expect successful result
try => expect error

Member

schlessera commented Feb 15, 2018

@BhargavBhandari90 When you run a test that expects an error to be thrown, like it is the case here, you need to use And I try ..., not And I run ....
run => expect successful result
try => expect error

@gitlost

This comment has been minimized.

Show comment
Hide comment
@gitlost

gitlost Feb 15, 2018

Contributor

The other failures happening are due to the BC break and are mentioned here #84 (comment). So those tests will have to be adjusted (assuming everyone's ok with the BC break).

Contributor

gitlost commented Feb 15, 2018

The other failures happening are due to the BC break and are mentioned here #84 (comment). So those tests will have to be adjusted (assuming everyone's ok with the BC break).

Show outdated Hide outdated features/plugin-uninstall.feature
Show outdated Hide outdated features/plugin-uninstall.feature
Show outdated Hide outdated features/plugin-uninstall.feature
Show outdated Hide outdated features/plugin-uninstall.feature
Show outdated Hide outdated features/plugin-uninstall.feature
Show outdated Hide outdated features/plugin-uninstall.feature
@schlessera

This comment has been minimized.

Show comment
Hide comment
@schlessera

schlessera Feb 19, 2018

Member

@BhargavBhandari90 I've added a few change requests.

For the basic tests setup, it should always read like normal sentences:

When ___
Then ___
And ___
[ And ___ ]
[ And ___ ]
...

When ___
Then ___
And ___
[ And ___ ]
[ And ___ ]
...
Member

schlessera commented Feb 19, 2018

@BhargavBhandari90 I've added a few change requests.

For the basic tests setup, it should always read like normal sentences:

When ___
Then ___
And ___
[ And ___ ]
[ And ___ ]
...

When ___
Then ___
And ___
[ And ___ ]
[ And ___ ]
...
@BhargavBhandari90

This comment has been minimized.

Show comment
Hide comment
@BhargavBhandari90

BhargavBhandari90 Feb 25, 2018

Contributor

@schlessera, Done with the changes. Please review.

Contributor

BhargavBhandari90 commented Feb 25, 2018

@schlessera, Done with the changes. Please review.

@schlessera schlessera merged commit a4a2553 into wp-cli:master Feb 25, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@schlessera

This comment has been minimized.

Show comment
Hide comment
@schlessera

schlessera Feb 25, 2018

Member

Thanks for the PR, @BhargavBhandari90 !

Member

schlessera commented Feb 25, 2018

Thanks for the PR, @BhargavBhandari90 !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment