Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow for modern-wordpress redirect; explicit list not search in upgr… #85

Merged
merged 2 commits into from Feb 13, 2018

Conversation

2 participants
@gitlost
Copy link
Contributor

gitlost commented Feb 12, 2018

Adjusts plugin slug not matching project name test to allow for redirect (should have https://github.com/wp-cli-test package for this but doing this as a temporary fix so #84 can progress).

Changes upgradables test to check for not installed by listing the item explicitly (probably what was intended originally) rather than searching and being dependent on the vagaries of the wordpress.org api.

@gitlost gitlost added this to the 1.1.10 milestone Feb 12, 2018

@gitlost

This comment has been minimized.

Copy link
Contributor Author

gitlost commented Feb 12, 2018

Okay trunk changed to using the info/1.2 api https://core.trac.wordpress.org/ticket/43192. This probably means that this data-specific check CommandWithUpgrade.php#L195 should be adjusted to take account of WP version but for the moment I'll just make the tests agnostic.

@gitlost gitlost requested a review from wp-cli/committers Feb 12, 2018

@danielbachhuber danielbachhuber merged commit 5a4bfac into master Feb 13, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@danielbachhuber danielbachhuber deleted the fix-plugin-install-upgradables-tests branch Feb 13, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.