New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adapt signing procedure to use proper key #232

Merged
merged 2 commits into from Jun 1, 2018

Conversation

2 participants
@schlessera
Member

schlessera commented May 31, 2018

No description provided.

@schlessera schlessera added this to the 2.0.0 milestone May 31, 2018

@schlessera schlessera requested a review from wp-cli/committers May 31, 2018

@danielbachhuber

This comment has been minimized.

Show comment
Hide comment
@danielbachhuber

danielbachhuber May 31, 2018

Member

How is the key itself shared?

Member

danielbachhuber commented May 31, 2018

How is the key itself shared?

@schlessera

This comment has been minimized.

Show comment
Hide comment
@schlessera

schlessera Jun 1, 2018

Member

@danielbachhuber That's up for internal discussion. I don't think there's any benefit in sharing this publically, in case our chosen method has flaws.

Member

schlessera commented Jun 1, 2018

@danielbachhuber That's up for internal discussion. I don't think there's any benefit in sharing this publically, in case our chosen method has flaws.

@schlessera schlessera merged commit 3050203 into master Jun 1, 2018

@schlessera schlessera deleted the adapt-signing-procedure branch Jun 1, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment