Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Workaround for parsing dynamic imports #164

Merged
merged 4 commits into from Jul 24, 2019

Conversation

@michaelzangl
Copy link
Contributor

commented Apr 28, 2019

Peast does not support dynamic import syntax
mck89/peast#7

This is a workaround for dynamic imports (to silently ignore them, they don't affect i18n generation).

@michaelzangl michaelzangl requested a review from wp-cli/committers as a code owner Apr 28, 2019

@swissspidy

This comment has been minimized.

Copy link
Member

commented May 18, 2019

For the record, the upstream issue was closed with the following explanation:

As you can see here dynamic import is still a proposal, it's not in the official ECMAScript specification yet and that's why it's not supported at the moment. I know some browsers already implement it, but i want this project to be conformant to the specs since proposals can change at any time until they get included.

@swissspidy
Copy link
Member

left a comment

No strong opinion here but I guess it's alright 🤷‍♂

@schlessera schlessera added this to the 2.2.0 milestone Jul 23, 2019

@schlessera schlessera merged commit 6c1535e into wp-cli:master Jul 24, 2019

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@schlessera schlessera changed the title Workaround for parsing dynamic import. Workaround for parsing dynamic imports Jul 24, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants
You can’t perform that action at this time.