Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sort translation files by name to ensure same order on all systems #173

Merged
merged 1 commit into from Jul 23, 2019

Conversation

@l3ku
Copy link
Contributor

commented Jul 19, 2019

See #171 for a better explanation on why to sort the translation files.

@l3ku l3ku requested a review from wp-cli/committers as a code owner Jul 19, 2019

@swissspidy

This comment has been minimized.

Copy link
Member

commented Jul 19, 2019

Would you mind adding some tests demonstrating that this works? :-)

@l3ku l3ku force-pushed the l3ku:master branch from 2ebbcca to c0ee850 Jul 19, 2019

@l3ku

This comment has been minimized.

Copy link
Contributor Author

commented Jul 19, 2019

I have now included a test case into /tests/IterableCodeExtractorTest.php. I did not add any new test data files into /tests/data, do you think that validating that all of the already existing files are returned in the intended order is sufficient or should I make the test more extensive?

@swissspidy swissspidy requested a review from wp-cli/committers Jul 23, 2019

@l3ku l3ku force-pushed the l3ku:master branch from c0ee850 to 11fdcef Jul 23, 2019

@schlessera schlessera added this to the 2.2.0 milestone Jul 23, 2019

@schlessera schlessera merged commit 4ab93fd into wp-cli:master Jul 23, 2019

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants
You can’t perform that action at this time.