Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add `--debug` output for the file being processed. #183

Merged
merged 2 commits into from Oct 22, 2019

Conversation

@ocean90
Copy link
Contributor

ocean90 commented Oct 18, 2019

For debugging purposes it would be helpful to know what file is currently processed.

Initially suggested by @schlessera.

src/JsCodeExtractor.php Outdated Show resolved Hide resolved
@schlessera

This comment has been minimized.

Copy link
Member

schlessera commented Oct 21, 2019

@ocean90 Using sprintf() and multiple lines here is overkill and detracts from the actual logic. I'd prefer each of these to be single lines instead.

@schlessera schlessera added this to the 2.2.1 milestone Oct 22, 2019
@schlessera

This comment has been minimized.

Copy link
Member

schlessera commented Oct 22, 2019

All failures unrelated (and waiting for php-gettext/Gettext#231 to get solved), so merging as-is.

@schlessera schlessera merged commit 96e74a5 into wp-cli:master Oct 22, 2019
1 check failed
1 check failed
continuous-integration/travis-ci/pr The Travis CI build failed
Details
@ocean90 ocean90 deleted the ocean90:feature/debug-message-file-parsing branch Oct 22, 2019
@kkmuffme kkmuffme mentioned this pull request Nov 15, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants
You can’t perform that action at this time.