Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correctly pass exclude option to JsCodeExtractor #37

Merged
merged 1 commit into from Jul 10, 2018

Conversation

2 participants
@swissspidy
Copy link
Member

swissspidy commented Jul 6, 2018

This fixes an oversight after working on #26 and #31 simultaneously.

When fixing the merge conflict for the JS extraction PR, I probably forgot to pass the exclude option to the JS scanner as well.

Just noticed this after I ran into a timeout trying to extract strings from hundreds of JS files inside vendor 馃檭

Added a test to make sure JS files are taken into account as well.

@swissspidy swissspidy requested a review from wp-cli/committers Jul 6, 2018

@schlessera schlessera added this to the 0.1.0 milestone Jul 10, 2018

@schlessera schlessera merged commit 9b2c03f into master Jul 10, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@schlessera schlessera deleted the fix-exclude-option branch Jul 10, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can鈥檛 perform that action at this time.
You signed in with another tab or window. Reload to refresh your session. You signed out in another tab or window. Reload to refresh your session.