New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add option to extract strings with any text domain #38

Merged
merged 1 commit into from Jul 10, 2018

Conversation

2 participants
@swissspidy
Collaborator

swissspidy commented Jul 6, 2018

This even allows extracting strings without any domain, which wasn't possible before.

That would be useful for projects like core (see #36) and private projects that aren't on WordPress.org.

Fixes #35.

@swissspidy swissspidy requested a review from wp-cli/committers Jul 6, 2018

}
list( $original, $domain ) = $args;
list( $original, $domain ) = array_pad( $args, 2, null );

This comment has been minimized.

@schlessera

schlessera Jul 10, 2018

Member

Ah, padding with null to avoid PHP errors when you're short on arguments. Nice one!

@schlessera

schlessera Jul 10, 2018

Member

Ah, padding with null to avoid PHP errors when you're short on arguments. Nice one!

@schlessera schlessera added this to the 0.1.0 milestone Jul 10, 2018

@schlessera schlessera merged commit 347fd22 into master Jul 10, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@schlessera schlessera deleted the ignore-domain branch Jul 10, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment