Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add `@when before_wp_load` to command namespace #42

Merged
merged 1 commit into from Jul 10, 2018

Conversation

2 participants
@swissspidy
Copy link
Member

swissspidy commented Jul 10, 2018

Before this PR:

$ wp i18n
Error: Error establishing a database connection. This either means that the username and password information in your `wp-config.php` file is incorrect or we can’t contact the database server at `localhost`. This could mean your host’s database server is down.

With this PR:

$ wp i18n
usage: wp i18n make-pot <source> [<destination>] [--slug=<slug>] [--domain=<domain>] [--merge[=<file>]] [--exclude=<paths>] [--skip-js]

See 'wp help i18n <command>' for more information on a specific command.

Fixes #40.

@schlessera

This comment has been minimized.

Copy link
Member

schlessera commented on b2cc682 Jul 10, 2018

@swissspidy No issue here, but please default to PRs in the future, not direct commits, even if it is only about a small change.

This comment has been minimized.

Copy link
Member

schlessera replied Jul 10, 2018

Huh? I swear Github showed me this commit on master... Nevermind!

@swissspidy swissspidy requested a review from wp-cli/committers Jul 10, 2018

@schlessera schlessera added this to the 0.1.0 milestone Jul 10, 2018

@swissspidy

This comment has been minimized.

Copy link
Member Author

swissspidy commented Jul 10, 2018

@schlessera No worries. To prevent accidental commits to master we could always protect the branch in the repository settings.

@swissspidy swissspidy merged commit e8cc5ef into master Jul 10, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@swissspidy swissspidy deleted the before-wp-load branch Jul 10, 2018

@schlessera

This comment has been minimized.

Copy link
Member

schlessera commented Jul 10, 2018

The master branch is already protected. I was just delusional, that must be it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.
You signed in with another tab or window. Reload to refresh your session. You signed out in another tab or window. Reload to refresh your session.