New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Factor directory iterator as a trait #54

Merged
merged 4 commits into from Jul 31, 2018

Conversation

3 participants
@drzraf
Contributor

drzraf commented Jul 24, 2018

Factor directory iterator as a trait so that other extractor can rely on it and make extension generic so that test (<extension> === 'php') can be overridden if needed.

Factor directory iterator as a trait so that other extractor can rely…
… on it.

and make extension generic so that test (<extension> === 'php') can be overriden if needed.

@drzraf drzraf changed the title from Factor directory iterator as a trait so that other extractor can rely… to Factor directory iterator as a trait Jul 24, 2018

@swissspidy

This comment has been minimized.

Show comment
Hide comment
@swissspidy

swissspidy Jul 24, 2018

Collaborator

That would need the same change for the JS extractor to make things DRY.

Collaborator

swissspidy commented Jul 24, 2018

That would need the same change for the JS extractor to make things DRY.

@swissspidy swissspidy requested a review from schlessera Jul 28, 2018

@schlessera schlessera added this to the 0.1.0 milestone Jul 31, 2018

@schlessera schlessera merged commit f9e94e8 into wp-cli:master Jul 31, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@schlessera

This comment has been minimized.

Show comment
Hide comment
@schlessera

schlessera Jul 31, 2018

Member

Thanks for the pull-request, @drzraf !

Member

schlessera commented Jul 31, 2018

Thanks for the pull-request, @drzraf !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment